Reviewed 56 of 56 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pinkisemils)

ios/MullvadRustRuntime/include/mullvad_rust_runtime.h line 101 at r1 (raw file):

                                         const uint8_t *raw_preshared_key,
                                         const uint8_t *raw_ephemeral_private_key);

A minor suggestion: maybe add a barrier comment saying that this is where shadowsocks begins, i.e., something like:

Code snippet:

//
// --- Shadowsocks
//

Reviewed 5 of 56 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @pinkisemils)

ios/MullvadRustRuntime/include/mullvad_rust_runtime.h line 1 at r1 (raw file):

#include <stdarg.h>

Is this file generated by mullvad-ios/build.rs? Could be worth adding a "warning, autogenerated" header here.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @pinkisemils)

mullvad-ios/src/post_quantum_proxy/ios_runtime.rs line 89 at r1 (raw file):

    pub fn run(self) {
        let runtime = mullvad_ios_runtime().expect("Could not get tokio runtime");

This is probably waaay out of scope but we might want to check so we don't panic unwind anywhere across the ffi.

Reviewed 26 of 56 files at r1.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @pinkisemils)

mullvad-ios/src/shadowsocks_proxy/bin/run.rs line 1 at r1 (raw file):

use std::{net::SocketAddr, str::FromStr};

I thought bins had to be placed in /src/bin?

Reviewable status: 45 of 56 files reviewed, 4 unresolved discussions (waiting on @acb-mv and @hulthe)

ios/MullvadRustRuntime/include/mullvad_rust_runtime.h line 1 at r1 (raw file):

It is auto-generated, and thus it might be a pain to add that header since it's regenerated on every build. The only reason it is in git is because Xcode won't attempt to run the build if the header isn't even there.

ios/MullvadRustRuntime/include/mullvad_rust_runtime.h line 101 at r1 (raw file):

Since it is autogenerated, the comments are lifted straight from the rust code.

mullvad-ios/src/post_quantum_proxy/ios_runtime.rs line 89 at r1 (raw file):

It really is not out of scope at all. I've changed it so that the FFI call returns an error early, and the handle to the runtime is passed down here.

mullvad-ios/src/shadowsocks_proxy/bin/run.rs line 1 at r1 (raw file):

This is a test binary, we probably don't want it here at all.

Reviewed 7 of 56 files at r1, 11 of 11 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @acb-mv)

mullvad-ios/src/post_quantum_proxy/ios_runtime.rs line 89 at r1 (raw file):

Nice, elegant fix.